fix: New livechat conversations are not assigned to contact manager #34210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02d5ef5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34210 +/- ##
============================================
+ Coverage 59.28% 75.27% +15.99%
============================================
Files 2820 516 -2304
Lines 67932 22540 -45392
Branches 15102 5485 -9617
============================================
- Hits 40275 16968 -23307
+ Misses 24831 4911 -19920
+ Partials 2826 661 -2165
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
requested changes
Dec 18, 2024
apps/meteor/ee/app/livechat-enterprise/server/hooks/handleNextAgentPreferredEvents.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/hooks/handleNextAgentPreferredEvents.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
requested changes
Dec 20, 2024
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Dec 23, 2024
KevLehman
approved these changes
Dec 23, 2024
|
/patch |
|
Pull request #34492 added to Project: "Patch 7.1.1" |
gabriellsh
pushed a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
contactManagerproperty stored in contacts when deciding the default new agent to assign to a livechat room (instead of only considering thecontactManagerfield in visitors, which is not maintained anymore).Issue(s)
Steps to test or reproduce
In a Premium workspace, enable the "Assign new conversations to the contact manager" setting under Settings > Omnichannel > Routing. Then create a new contact manually (in the livechat contact center) using a livechat agent and assign yourself user as the contact manager (use the
contacts.getendpoint to make sure thecontactManagerfield contains the user id of the agent who created the contact). Then start a new livechat conversation using the info from the contact that has just been created.Expected result: the contact manager should be automatically assigned to the room if it is online.
Note: use "Auto Selection" as the "Omnichannel Routing Method" (under Settings > Omnichannel > Routing). Otherwise, only bot contact managers will be auto assigned to rooms.
Further comments
CORE-862